Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system] Remove getInitColorSchemeScript leading spaces #38794

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 3, 2023

When you look at the source of the page:

Before: view-source:https://mui.com/
Screenshot 2023-09-04 at 01 53 19

After: view-source:https://deploy-preview-38794--material-ui.netlify.app/
Screenshot 2023-09-04 at 01 53 25

it's easier to understand.

@oliviertassinari oliviertassinari added package: system Specific to @mui/system performance enhancement This is not a bug, nor a new feature and removed performance labels Sep 3, 2023
@mui-bot
Copy link

mui-bot commented Sep 3, 2023

Netlify deploy preview

https://deploy-preview-38794--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 0939b94

@oliviertassinari
Copy link
Member Author

In https://github.com/pacocoursey/next-themes, there render the script without line breaks, but I guess it's better like this for readability.

Screenshot 2023-09-10 at 02 06 34

view-source:https://next-themes-example.vercel.app/

@oliviertassinari oliviertassinari changed the title [system] Remove leading spaces [system] Remove getInitColorSchemeScript leading spaces Sep 10, 2023
@oliviertassinari oliviertassinari merged commit 8dd133f into mui:master Sep 10, 2023
@oliviertassinari oliviertassinari deleted the remove-line-breaks branch September 10, 2023 00:12
xcode-it pushed a commit to xcode-it/material-ui that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature package: system Specific to @mui/system performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants